[Parser] Eliminate 'CommentRetentionMode::None' in Lexer #85927
+45
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
CodaFi,
DougGregor,
bnbarham,
hamishknight,
hborla,
slavapestov and
xedin
as code owners
hamishknight
approved these changes
Dec 9, 2025
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please smoke test macOS |
Member
Author
|
@swift-ci Please smoke test Linux |
Lexer should always set `Token.CommentLength` correctly because it necessary for restoring to the token position with comments. Otherwise, 'Token::isAtStartOfLine()' might not correctly set.
rintaro
commented
Dec 10, 2025
unittests/Parse/LexerTests.cpp
Outdated
| Lexer L(LangOpts, SourceMgr, BufferID, /*Diags=*/nullptr, LexerMode::Swift, | ||
| HashbangMode::Disallowed, CommentRetentionMode::None); | ||
| HashbangMode::Disallowed, CommentRetentionMode::AttachToNextToken); |
Member
Author
There was a problem hiding this comment.
This was specifically testing CommentRetentionMode::None behavior. Removing the case.
(CommentRetentionMode::AttachToNextToken behavior is tested in BOMAttachCommentNoTrivia)
rintaro
force-pushed
the
parser-comment-retention
branch
from
53fdf19 to
dffd88e
Compare
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please smoke test Linux |
Member
Author
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #85922
Lexer should always set
Token.CommentLengthcorrectly because it's necessary for restoring the token position with comments. Otherwise,Token::isAtStartOfLine()might not correctly set. (see:Lexer::getStateForBeginningOfToken())